Monday, April 25, 2011

What's the correct way of using bitfields in C?

Hello all, I am using bitfields to get easy access on a float library I am trying to make for a microcontroller with no FPU.

The problem is that I can't seem to make it work with bitfields. Take a look:

typedef struct
{
   union{
    unsigned long mantissa: 23;
    unsigned long exponent: 8;
    unsigned long sign: 1;
 float all;

      };

}_float __attribute__((__packed__));

The problem is that when I try to access or change anything it considers the bitfields as 1,8,23 bits from the end respectively. While it should be 23 bits from the end, then 8 bits and then the last bit. Unless I have totally misunderstood the use of bitfields. I thought that using packed would solve the problem but as you can see it didn't.

Any help would be really appreciated. I have been lead to this site while googling more than once so I have high hopes.

From stackoverflow
  • You might be missing a struct inside your union.

    typedef struct
    {
        union{
           struct {
               unsigned long mantissa: 23;
               unsigned long exponent: 8;
               unsigned long sign: 1;
           } float_parts;
           float all;
        };
    }_float __attribute__((__packed__));
    

    Note that the order of mantissa/exponent and sign depends one the endianess of the cpu.

    rmeador : a union will make ALL its members share the same memory. I don't think using bitfields will change this behavior, so all your bitfields start at bit 0, just like the "all" float does. Putting them in a struct makes the laid out sequentially.
  • The problem is that it is a union. It should be 'struct'.

  • If you are on a glibc platform you can take a look on the ieee754.h header file. It takes care about the endianess stuff. If not it's still probably worth to take a look on it.

0 comments:

Post a Comment